4.17-stable review patch. If anyone has any objections, please let me know.
------------------
From: Philippe CORNU philippe.cornu@st.com
[ Upstream commit c20f5f69c898899027c3e573afaab837195895b6 ]
Fix the warning "warn: variable dereferenced before check 'crtc' (see line 390)" by removing unnecessary checks as ltdc_crtc_update_clut() is only called from ltdc_crtc_atomic_flush() where crtc and crtc->state are not NULL.
Many thanks to Dan Carpenter for the bug report https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html
Signed-off-by: Philippe Cornu philippe.cornu@st.com Reported-by: Dan Carpenter dan.carpenter@oracle.com Reviewed-by: yannick fertre yannick.fertre@st.com Link: https://patchwork.freedesktop.org/patch/msgid/20180410135312.3553-1-philippe... Signed-off-by: Sasha Levin alexander.levin@microsoft.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-)
--- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -392,9 +392,6 @@ static void ltdc_crtc_update_clut(struct u32 val; int i;
- if (!crtc || !crtc->state) - return; - if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut) return;