On Thu, Oct 23, 2025 at 11:11:00AM -0500, Bjorn Helgaas wrote:
On Thu, Oct 23, 2025 at 09:03:07AM +0200, Stefan Roese wrote:
On 10/23/25 08:35, Musham, Sai Krishna wrote:
-----Original Message----- From: Stefan Roese stefan.roese@mailbox.org On 10/22/25 14:48, Musham, Sai Krishna wrote:
...
> We even don’t need ravi patch, as we have tested this at > our end it works fine by just updating interrupt-map > Property. We need to now understand the difference in > design.
Ok, please let us know with your findings. In the meantime, I'll keep Ravi's patch in tree, as it seems to be required on his setup.
We tested on Linux version 6.12.40 without applying either Stefan's or Ravi's patches. Instead, we applied only the following interrupt-map property change (entries 0,1,2,3) and verified that legacy interrupts are working correctly.
interrupt-map = <0 0 0 1 &pcie_intc_0 0>, <0 0 0 2 &pcie_intc_0 1>, <0 0 0 3 &pcie_intc_0 2>, <0 0 0 4 &pcie_intc_0 3>;
38: 1143 0 pl_dma:RC-Event 16 Level 80000000.axi-pcie 39: 1143 0 pl_dma:INTx 0 Level nvme0q0, nvme0q1
Okay. Same here. I don't need Ravi's patch for the INTx bit enabling.
I understand that you want us to change the interrupt map in the auto- generated device-tree from Vivado. Which is IMHO a bit "suboptimal".
I would prefer to have a solution which works out-of-the-box, w/o the need to manually change DT properties. Is it planned to change / fix this interrupt map in pl.dtsi generated with a newer version of Vivado?
Yes Stefan, this will be fixed in the newer versions and the auto-generated device tree will include the correct interrupt-map property entries.
Understood. And thanks the update on this.
@Bjorn & Mani, this patch can be dropped then.
Just to confirm, we can drop both of these patches:
https://patch.msgid.link/20250920225232.18757-1-ravib@amazon.com https://patch.msgid.link/20251021154322.973640-1-stefan.roese@mailbox.org
AND there are no DTs in the field that will need to be updated for things to work?
There are no upstream DTs making use of this driver. Also, the upstream binding example seems to be correct:
interrupt-map = <0 0 0 1 &pcie_intc_0 0>, <0 0 0 2 &pcie_intc_0 1>, <0 0 0 3 &pcie_intc_0 2>, <0 0 0 4 &pcie_intc_0 3>;
Moreover, if any DTs were using different 'interrupt-map' property, then INTx wouldn't be working for them. So most likely they were all using MSIs as we haven't received any reports up until now.
Hence, IMO we should be good to ignore the patch from Stefan. Though, I still have a concern on whether the hardware is enabling INTx by default or not [1]. Until that is concluded, we should keep Ravi's patch.
- Mani
[1] https://lore.kernel.org/linux-pci/DM4PR12MB6158C6E6D6CC8BBCD5F6C3B1CDF0A@DM4...