On Sat, 3 May 2025 09:02:58 -0300 Fabio Estevam festevam@gmail.com wrote:
On Wed, Apr 30, 2025 at 4:37 PM Fabio Estevam festevam@gmail.com wrote:
I have applied your suggestion.
Please take a look and let me know your thoughts.
--- a/drivers/iio/adc/max1363.c +++ b/drivers/iio/adc/max1363.c @@ -504,10 +504,10 @@ static const struct iio_event_spec max1363_events[] = { MAX1363_CHAN_U(1, _s1, 1, bits, ev_spec, num_ev_spec), \ MAX1363_CHAN_U(2, _s2, 2, bits, ev_spec, num_ev_spec), \ MAX1363_CHAN_U(3, _s3, 3, bits, ev_spec, num_ev_spec), \
MAX1363_CHAN_B(0, 1, d0m1, 4, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(2, 3, d2m3, 5, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(1, 0, d1m0, 6, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(3, 2, d3m2, 7, bits, ev_spec, num_ev_spec), \
MAX1363_CHAN_B(0, 1, d0m1, 12, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(2, 3, d2m3, 13, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(1, 0, d1m0, 14, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(3, 2, d3m2, 15, bits, ev_spec, num_ev_spec), \ IIO_CHAN_SOFT_TIMESTAMP(8) \I have also tried changing it like this:
--- a/drivers/iio/adc/max1363.c +++ b/drivers/iio/adc/max1363.c @@ -504,10 +504,10 @@ static const struct iio_event_spec max1363_events[] = { MAX1363_CHAN_U(1, _s1, 1, bits, ev_spec, num_ev_spec), \ MAX1363_CHAN_U(2, _s2, 2, bits, ev_spec, num_ev_spec), \ MAX1363_CHAN_U(3, _s3, 3, bits, ev_spec, num_ev_spec), \
MAX1363_CHAN_B(0, 1, d0m1, 4, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(2, 3, d2m3, 5, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(1, 0, d1m0, 6, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(3, 2, d3m2, 7, bits, ev_spec, num_ev_spec), \
MAX1363_CHAN_B(0, 1, d0m1, 28, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(2, 3, d2m3, 29, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(1, 0, d1m0, 30, bits, ev_spec, num_ev_spec), \MAX1363_CHAN_B(3, 2, d3m2, 31, bits, ev_spec, num_ev_spec), \ IIO_CHAN_SOFT_TIMESTAMP(8) \ }In this case, the warnings are gone.
Should the masks be 32-bit?
Their depth depends on particular channels but is between 18 and 24 (assuming I'm finally reading the tables right!)
Jonathan
Thanks