Re: [PATCH v4 2/6] PCI: aardvark: Fix logic in advk_pcie_valid_device()

Hi Thomas,

On jeu., mars 29 2018, Thomas Petazzoni thomas.petazzoni@bootlin.com wrote:

From: Victor Gu xigu@marvell.com

The PCI configuration space read/write functions were special casing

causing? else I don't get it

the situation where PCI_SLOT(devfn) != 0, and returned PCIBIOS_DEVICE_NOT_FOUND in this case.

However, while this is what is intended for the root bus, it is not intended for the child busses, as it prevents discovering devices with

buses

PCI_SLOT(x) != 0. Therefore, we return PCIBIOS_DEVICE_NOT_FOUND only if we're on the root bus.

Gregory