Re: [PATCH 1/2] PCI: dra7xx: Fix threaded IRQ request for "dra7xx-pcie-main" IRQ

On Tue, Aug 27, 2024 at 05:54:21PM +0530, Siddharth Vadapalli wrote:

Commit da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ") switched from devm_request_irq() to devm_request_threaded_irq() for the "dra7xx-pcie-main" interrupt. Since the primary handler was set to NULL, the "IRQF_ONESHOT" flag should have also been set. Fix this.

Fixes: da87d35a6e51 ("PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ") Cc: stable@vger.kernel.org Reported-by: Udit Kumar u-kumar1@ti.com Suggested-by: Vignesh Raghavendra vigneshr@ti.com Signed-off-by: Siddharth Vadapalli s-vadapalli@ti.com

Reviewed-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org

- Mani

---

drivers/pci/controller/dwc/pci-dra7xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 4fe3b0cb72ec..20fb50741f3d 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -850,7 +850,8 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) dra7xx->mode = mode; ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler,

• 	       IRQF_SHARED, "dra7xx-pcie-main", dra7xx);
  

• 			IRQF_SHARED | IRQF_ONESHOT,
  

• 			"dra7xx-pcie-main", dra7xx);
  

  if (ret) { dev_err(dev, "failed to request irq\n"); goto err_gpio;

-- 2.40.1