Re: [PATCH v4] lib/string.c: implement a basic bcmp

On Thu, 21 Mar 2019 10:02:37 -0700 Nick Desaulniers ndesaulniers@google.com wrote:

Shall I send you a cleanup removing the undefs for bcmp, memcmp, strcat, strcpy, and strcmp? Of those, I only see memcmp being `#defined` in arch/m68k/include/asm/string.h, arch/x86/boot/string.h, and arch/x86/include/asm/string_32.h.

Further, I can drop some of the __GNUC__ < 4 code in arch/x86/include/asm/string_32.h. (grepping for __GNUC__, looks like there's a fair amount of code that can be cleaned up). We should probably check it since Clang lies about being GCC 4.2 compatible, which will surely break in horrific ways at some point.\

All sounds good. Some time, when convenient, thanks.