On Mon, Feb 17, 2025 at 11:31:46PM +0800, Haoxiang Li wrote:
Add check for the return value of get_zeroed_page() in sclp_console_init() to prevent null pointer dereference.
Fixes: 4c8f4794b61e ("[S390] sclp console: convert from bootmem to slab") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li haoxiang_li2024@163.com
drivers/s390/char/sclp_con.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/s390/char/sclp_con.c b/drivers/s390/char/sclp_con.c index e5d947c763ea..7447076b1ec1 100644 --- a/drivers/s390/char/sclp_con.c +++ b/drivers/s390/char/sclp_con.c @@ -282,6 +282,8 @@ sclp_console_init(void) /* Allocate pages for output buffering */ for (i = 0; i < sclp_console_pages; i++) { page = (void *) get_zeroed_page(GFP_KERNEL | GFP_DMA);
if (!page)return -ENOMEM;
We can add this check, however if this early allocation would fail a null pointer dereference would be the last problem we would have to think about.
Anyway: Acked-by: Heiko Carstens hca@linux.ibm.com