Hello Chen-Yu,
On 2024-10-25 16:47, Chen-Yu Tsai wrote:
On Wed, Oct 23, 2024 at 5:11 AM Dragan Simic dsimic@manjaro.org wrote:
On 2024-09-19 21:15, Dragan Simic wrote:
The way InvenSense MPU-6050 accelerometer is mounted on the user-facing side of the Pine64 PinePhone mainboard, which makes it rotated 90 degrees counter- clockwise, [1] requires the accelerometer's x- and y-axis to be swapped, and the direction of the accelerometer's y-axis to be inverted.
Rectify this by adding a mount-matrix to the accelerometer definition in the Pine64 PinePhone dtsi file.
[1] https://files.pine64.org/doc/PinePhone/PinePhone%20mainboard%20bottom%20plac...
Fixes: 91f480d40942 ("arm64: dts: allwinner: Add initial support for Pine64 PinePhone") Cc: stable@vger.kernel.org Helped-by: Ondrej Jirman megi@xff.cz Helped-by: Andrey Skvortsov andrej.skvortzov@gmail.com Signed-off-by: Dragan Simic dsimic@manjaro.org
Just a brief reminder about this patch... Please, let me know if some further work is needed for it to become accepted.
There's no "Helped-by" tag, and checkpatch would complain. The closest would be either Suggested-by or Co-developed-by, but with the latter you would also need their Signed-off-by.
Thanks for your response. You're totally right about checkpatch.pl not supporting Helped-by tags, but including neither Suggested-by nor Co-developed-by would fit very well in this case, because the associated level of credit falls right somewhere between what's indicated by these two tags.
I can change it to Suggested-by if that's OK with you.
I've created and submitted a patch [*] that adds support for Helped-by tags to checkpatch.pl. Let's see what kind of feedback that patch will receive, and then we'll be able to move forward accordingly.
[*] https://lore.kernel.org/linux-kernel/0e1ef28710e3e49222c966f07958a9879fa4e90...
Notes: See also the linux-sunxi thread [2] that has led to this patch, which provides a rather detailed analysis with additional details and pictures. This patch effectively replaces the patch submitted in that thread.
[2]https://lore.kernel.org/linux-sunxi/20240916204521.2033218-1-andrej.skvortzo...
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 6eab61a12cd8..b844759f52c0 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -212,6 +212,9 @@ accelerometer@68 { interrupts = <7 5 IRQ_TYPE_EDGE_RISING>; /* PH5 */ vdd-supply = <®_dldo1>; vddio-supply = <®_dldo1>;
mount-matrix = "0", "1", "0","-1", "0", "0","0", "0", "1"; };};