Re: [PATCH 5.10 006/173] ipmi:ssif: resend_msg() cannot fail

Hi!

The resend_msg() function cannot fail, but there was error handling around using it. Rework the handling of the error, and fix the out of retries debug reporting that was wrong around this, too.

@@ -909,31 +909,17 @@ static void msg_written_handler(struct ssif_info *ssif_info, int result, if (result < 0) { ssif_info->retries_left--; if (ssif_info->retries_left > 0) {

• 	if (!start_resend(ssif_info)) {
  

• 		ssif_inc_stat(ssif_info, send_retries);
  

• 		return;
  

• 	}
  

• 	/* request failed, just return the error. */
  

• 	ssif_inc_stat(ssif_info, send_errors);
  

• 	if (ssif_info->ssif_debug & SSIF_DEBUG_MSG)
  

• 		dev_dbg(&ssif_info->client->dev,
  

• 			"%s: Out of retries\n", __func__);
  

• 	msg_done_handler(ssif_info, -EIO, NULL, 0);
  

• 	start_resend(ssif_info);
  return;
  

  }

ssif_inc_stat(ssif_info, send_errors); disappeared here, is that intentional?

Best regards, Pavel