Re: [PATCH v2] arm64: fix cleared E0POE bit after cpu_suspend()/resume()

Hi Kevin,

[...]

...

@@ -144,6 +148,10 @@ SYM_FUNC_START(cpu_do_resume) msr tcr_el1, x8 msr vbar_el1, x9 msr mdscr_el1, x10 +alternative_if ARM64_HAS_TCR2

• ldr x2, [x0, #104]
• msr REG_TCR2_EL1, x2

+alternative_else_nop_endif

Maybe this could be pushed further down cpu_do_resume, next to DISR_EL1 maybe (since it's also conditional)? Otherwise the diff LGTM:

Sorry but IIUC, currently there is no DISR_EL1 save/restore not yet? and I think current place is good where before restore SCTLR_EL1 which before MMU enabled.

Am I missing something?

Thanks.

-- Sincerely, Yeoreum Yun