Re: [PATCH] xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n

On Tue, Jan 14, 2025 at 10:20:37PM -0800, Darrick J. Wong wrote:

Good point, we could cut it off right then and there. Though this seems a little gross:

if (xchk_could_repair(sc)) #ifdef CONFIG_XFS_ONLINE_REPAIR sc->sm->sm_flags |= XFS_SCRUB_OFLAG_CORRUPT; #else return -EOPNOTSUPP; #endif return 0;

but I don't mind. Some day the stubs will go away, fingers crossed.

We'll I'd write it as:

if (xchk_could_repair(sc)) { if (!IS_ENABLED(CONFIG_XFS_ONLINE_REPAIR)) return -EOPNOTSUPP; sc->sm->sm_flags |= XFS_SCRUB_OFLAG_CORRUPT; }

but I'm fine with either version:

Reviewed-by: Christoph Hellwig hch@lst.de