Hi,
On Mon, Sep 2, 2024 at 8:26 AM Johan Hovold johan+linaro@kernel.org wrote:
+static void qcom_geni_serial_drain_fifo(struct uart_port *uport) +{
struct qcom_geni_serial_port *port = to_dev_port(uport);if (!qcom_geni_serial_main_active(uport))return;
It seems like all callers already do the check and only ever call you if the port is active. Do you really need to re-check?
@@ -308,6 +311,17 @@ static bool qcom_geni_serial_poll_bit(struct uart_port *uport, return qcom_geni_serial_poll_bitfield(uport, offset, field, set ? field : 0); }
+static void qcom_geni_serial_drain_fifo(struct uart_port *uport) +{
struct qcom_geni_serial_port *port = to_dev_port(uport);if (!qcom_geni_serial_main_active(uport))return;qcom_geni_serial_poll_bitfield(uport, SE_GENI_M_GP_LENGTH, GP_LENGTH,port->tx_queued);
nit: indent "port->tx_queued" to match open parenthesis?
...also: as the kernel test robot reported, w/ certain CONFIGs this is defined / not used.
Aside from the nit / robot issue, this solution looks reasonable to me. It's been long enough that I've already paged out much of the past digging I did into this driver, but this seems like it should work. Feel free to add my Reviewed-by when the robot issue is fixed.
-Doug