On Fri, Aug 24, 2018 at 4:08 PM Ben Hutchings ben.hutchings@codethink.co.uk wrote:
On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote:
4.4-stable review patch. If anyone has any objections, please let me know.
From: Nick Desaulniers ndesaulniers@google.com
commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream.
native_save_fl() is marked static inline, but by using it as a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
paravirt's use of native_save_fl() also requires that no GPRs other than %rax are clobbered.
[...]
Shouldn't native_restore_fl() be changed similarly? You added an out- of-line definition, but it doesn't seem like it will actually be used.
Good catch, will send a patch with your reported by. Thank you for the report.