Re: [PATCH 2/2] serial: 8250: Request full 16550A feature probing for OxSemi PCIe devices

On Mon, 19 Sep 2022, Jiri Slaby wrote:

...

linux-serial-8250-oxsemi-efr.diff Index: linux-macro/drivers/tty/serial/8250/8250_pci.c =================================================================== --- linux-macro.orig/drivers/tty/serial/8250/8250_pci.c +++ linux-macro/drivers/tty/serial/8250/8250_pci.c @@ -1232,6 +1232,10 @@ static void pci_oxsemi_tornado_set_mctrl serial8250_do_set_mctrl(port, mctrl); } +/*

• • We require EFR features for clock programming, so set UPF_FULL_PROBE
• • for full probing regardless of CONFIG_SERIAL_8250_16550A_VARIANTS

setting.

• */

It'd make more sense to me to move this comment right before the line you add below.

I favour the style where what a function does is documented above it, but I won't insist on it if having a comment within is what we prefer here.

Maciej