-----Original Message----- From: Jakub Kicinski kuba@kernel.org Sent: Tuesday, April 2, 2024 12:13 AM To: Dexuan Cui decui@microsoft.com Cc: Haiyang Zhang haiyangz@microsoft.com; linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; Wei Hu weh@microsoft.com; stephen stephen@networkplumber.org; KY Srinivasan kys@microsoft.com; Paul Rosswurm paulros@microsoft.com; olaf@aepfle.de; vkuznets@redhat.com; davem@davemloft.net; wei.liu@kernel.org; edumazet@google.com; pabeni@redhat.com; leon@kernel.org; Long Li longli@microsoft.com; ssengar@linux.microsoft.com; linux-rdma@vger.kernel.org; daniel@iogearbox.net; john.fastabend@gmail.com; bpf@vger.kernel.org; ast@kernel.org; sharmaajay@microsoft.com; hawk@kernel.org; tglx@linutronix.de; shradhagupta@linux.microsoft.com; linux- kernel@vger.kernel.org; stable@vger.kernel.org Subject: Re: [PATCH net] net: mana: Fix Rx DMA datasize and skb_over_panic
On Tue, 2 Apr 2024 01:23:08 +0000 Dexuan Cui wrote:
I suggest the Fixes tag should be updated. Otherwise the fix looks good to me.
Thanks for the suggestion. I actually thought about this before submission. I was worried about someone back ports the jumbo frame feature, they may not automatically know this patch should be backported too.
The jumbo frame commit (2fbbd712baf1) depends on the MTU commit (2fbbd712baf1), so adding "Fixes: 2fbbd712baf1" ( instead of "Fixes: ca9c54d2d6a5") might make it easier for people to notice and pick up this fix.
I'm OK if the patch remains as is. Just wanted to make sure I understand the issue here.
Please update the tag to where the bug was actually first exposed.
Thank Dexuan and Jakub for the suggestions. I will update the tag.
- Haiyang