On 11/26/25 3:47 AM, Jiri Slaby wrote:
On 11. 11. 25, 1:46, Greg Kroah-Hartman wrote:
6.17-stable review patch. If anyone has any objections, please let me know.
From: Henrique Carvalho henrique.carvalho@suse.com
commit 734e99623c5b65bf2c03e35978a0b980ebc3c2f8 upstream.
...
This _backport_ (of a 6.18-rc5 commit) omits to change cfids_invalidation_worker() which was removed in 6.18-rc1 by: 7ae6152b7831 smb: client: remove cfids_invalidation_worker
This likely causes: https://bugzilla.suse.com/show_bug.cgi?id=1254096 BUG: workqueue leaked atomic, lock or RCU
Because cfids_invalidation_worker() still does: kref_put(&cfid->refcount, smb2_close_cached_fid); instead of now required kref_put_lock() aka: close_cached_dir(cfid);
thanks,
Thanks, Jiri.
I'm sending the updated patch attached.
This new version should also replace the patch backported to stable versions:
- 6.12.y (065bd62412271a2d734810dd50336cae88c54427) - 6.6.y (cb52d9c86d70298de0ab7c7953653898cbc0efd6)
Alternatively, I'm sending just the fix ("smb: client: fix incomplete backport in cfids_invalidation_worker()").