On Mon, Sep 13, 2021 at 12:57 PM Sedat Dilek sedat.dilek@gmail.com wrote:
On Mon, Sep 13, 2021 at 9:53 PM 'Nick Desaulniers' via Clang Built Linux clang-built-linux@googlegroups.com wrote:
On Mon, Sep 13, 2021 at 11:39 AM Nick Desaulniers ndesaulniers@google.com wrote:
There's an issue with my alternative approach (https://gist.github.com/nickdesaulniers/2479818f4983bbf2d688cebbab435863) with declaring the local variable z in div_64() since either operand could be 64b, which result in an unwanted truncation if the dividend is 32b (or less, and divisor is 64b). I think (what I realized this weekend) is that we might be able to replace the `if` with `__builtin_choose_expr`, then have that whole expression be the final statement and thus the "return value" of the statement expression.
Christ...that...works? Though, did Linus just merge my patches for gcc 5.1?
"Merge branch 'gcc-min-version-5.1' (make gcc-5.1 the minimum version)"
Ha! I pulled+rebased and this code disappeared...I thought I had rebased on the wrong branch or committed work to master accidentally. Patch to stable-only inbound.