Re: [PATCH v2] ata: libata: avoid superfluous disk spin down + spin up during hibernation

On Wed, Oct 09, 2024 at 07:44:31PM +0900, Damien Le Moal wrote:

On 10/8/24 22:58, Niklas Cassel wrote:

...

A user reported that commit aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop") introduced a spin down + immediate spin up of the disk both when entering and when resuming from hibernation. This behavior was not there before, and causes an increased latency both when when entering and when resuming from hibernation.

One too many "when".

Will fix up when applying.

With the above nit fixed,

Reviewed-by: Damien Le Moal dlemoal@kernel.org

Thanks!