On Thu, Jan 7, 2021 at 4:43 PM Saravana Kannan saravanak@google.com wrote:
On Thu, Jan 7, 2021 at 4:14 PM Michael Walle michael@walle.cc wrote:
Am 2021-01-08 00:41, schrieb Saravana Kannan:
The device link device's name was of the form: <supplier-dev-name>--<consumer-dev-name>
This can cause name collision as reported here [1] as device names are not globally unique. Since device names have to be unique within the bus/class, add the bus/class name as a prefix to the device names used to construct the device link device name.
So the devuce link device's name will be of the form: <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>
[1] - https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
Cc: stable@vger.kernel.org Fixes: 287905e68dd2 ("driver core: Expose device link details in sysfs") Reported-by: Michael Walle michael@walle.cc Signed-off-by: Saravana Kannan saravanak@google.com
This makes it even worse. Please see below for a full bootlog with the dev_dbg() converted to dev_info() and initcall_debug enabled.
Sorry if I'm missing something obvious (been a long day), but how is it worse? I don't see any warnings in this log. I'll reply to your other emails separately.
Nevermind, I see it now. Also, in the future, if you can dump the logs in some kind of pastebin site, that'd be nice. Avoid the emails becoming unwieldy and also avoids the log lines from wrapping.
-Saravana