On Sat, May 23, 2020 at 12:10:27PM -0700, Linus Torvalds wrote:
On Sat, May 23, 2020 at 12:02 PM Mike Rapoport rppt@linux.ibm.com wrote:
Unfortunately, this fixes a compile warning but breaks the boot :(
Argh. I delayed applying/merging this overnight to see if there were any reports, but this came in after I'd already merged Andrew's patches and pushed them out.
Actually, it's really by chance I noticed it tonight, although still it was too late :)
So it's in my tree now as commit c2bc26f7ca1f ("sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()")
The correcteted patch is below, boot tested with qemu-systems-sparc.
Mind sending a patch relative to the previous one that already got merged?
Sure.
Also, would it perhaps be worth it to just make __nocache_fix() not throw the type away? IOW, make it do something like
#define __nocache_fix(VADDR) \ ((__typeof__(VADDR))__va(__nocache_pa(VADDR)))
or whatever? Wouldn't that show when those pgd/p4d/pud pointers get mis-used because they don't end up dropping the type info..
Yes, I'll look into it.
Linus