13 Mar
2019
13 Mar
'19
6:40 p.m.
On Wed, 13 Mar 2019 11:17:15 -0700 Nick Desaulniers ndesaulniers@google.com wrote:
+#ifndef __HAVE_ARCH_BCMP +/**
- bcmp - Like memcmp but a non-zero return code simply indicates a non-match.
- @cs: One area of memory.
- @ct: Another area of memory.
- @count: The size of the areas.
- */
+#undef bcmp +int bcmp(const void *cs, const void *ct, size_t count) +{
- return memcmp(cs, ct, count);
This is confusing where the comment says "like memcmp but .." and then just returns memcmp() unmodified. If anything, I would expect to see
return !!memcmp(cs, ct, conut);
or have a better comment explaining why its the same.
-- Steve
+} +EXPORT_SYMBOL(bcmp); +#endif