Re: [PATCH v2] drm/etnaviv: Fix driver unregistering

Hi Philipp,

On Mon, Jun 25, 2018 at 5:02 AM, Philipp Zabel p.zabel@pengutronix.de wrote:

...

+static struct platform_device *etnaviv_drm;

static int __init etnaviv_init(void) { int ret; @@ -654,7 +656,8 @@ static int __init etnaviv_init(void) if (!of_device_is_available(np)) continue;

•         platform_device_register_simple("etnaviv", -1, NULL, 0);
  

•         etnaviv_drm = platform_device_register_simple("etnaviv", -1,
  

•                                                       NULL, 0);
  

If there are multiple vivante,gc device nodes, this overwrites etnaviv_drm with each additional device after the first one.

In fact there are multiple vivante,gc device nodes, but platform_device_register_simple() is only called once as expected.

I will make this clear and will also check for the error code on platform_device_register_simple().

Thanks