Re: [PATCH] xen: detect uninitialized xenbus in xenbus_init

On 18.11.2021 23:24, Boris Ostrovsky wrote:

On 11/18/21 4:00 PM, Stefano Stabellini wrote:

...

     /*
      * Avoid truncation on 32-bit.
      * TODO: handle addresses >= 4G
      */
     if ( v >= ~0UL ) {
         err = -EINVAL;
         goto out_error;
     }

Since this is only relevant to 32-bit kernels then "#if BITS_PER_LONG == 32".

Plus then > instead of >= (thus also making the comment actually decribe the code) and ULONG_MAX instead of ~0UL, I would say.

Jan