Re: [PATCH v5 5/5] block: add __must_check attribute to sb_min_blocksize()

On 11/4/25 19:05, Christoph Hellwig wrote:

...

-extern int sb_min_blocksize(struct super_block *, int); +extern int __must_check sb_min_blocksize(struct super_block *, int);

Please drop the pointless extern here, and spell out the parameter names.

Otherwise looks good:

Reviewed-by: Christoph Hellwig hch@lst.de

Thanks for the review. I'll send v6 and fix it.

Yongpeng,