Hi again,
On Tue, Apr 29, 2025 at 07:34:21PM +0100, Daniel Golle wrote:
On Tue, Apr 29, 2025 at 06:42:51PM +0200, Greg Kroah-Hartman wrote:
5.15-stable review patch. If anyone has any objections, please let me know.
From: Daniel Golle daniel@makrotopia.org
[ Upstream commit 497041d763016c2e8314d2f6a329a9b77c3797ca ]
MT7531 standalone and MMIO variants found in MT7988 and EN7581 share most basic properties. Despite that, assisted_learning_on_cpu_port and mtu_enforcement_ingress were only applied for MT7531 but not for MT7988 or EN7581, causing the expected issues on MMIO devices.
Apply both settings equally also for MT7988 and EN7581 by moving both assignments form mt7531_setup() to mt7531_setup_common().
This fixes unwanted flooding of packets due to unknown unicast during DA lookup, as well as issues with heterogenous MTU settings.
Fixes: 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup")
The commit 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup") is only present since v6.4 so backport to 5.15 and 6.1 doesn't make sense
I should have actually checked and only now noticed that 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup") has been picked to stable kernels down to Linux 5.15.
However, the bug only affects MMIO variants of the switch which are supported since commit 110c18bfed414 ("net: dsa: mt7530: introduce driver for MT7988 built-in switch"), and that is present only since Linux 6.6.
Sorry about the confusion, I should have probably chosen that commit in the Fixes: tag despite the original mistake was introduced in commit 7f54cc9772ce ("net: dsa: mt7530: split-off common parts from mt7531_setup").