6.17-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alok Tiwari alok.a.tiwari@oracle.com
[ Upstream commit d586676a2714176bed06cf70467c4e08ac2d4681 ]
The variable 'err' is declared as u32, but it is used to store negative error codes such as -EINVAL.
Changing the type of 'err' to int ensures proper representation of negative error codes and aligns with standard kernel error handling conventions.
Also, there is no need to initialize 'err' since it is always set before being used.
Signed-off-by: Alok Tiwari alok.a.tiwari@oracle.com Reviewed-by: Shannon Nelson sln@onemain.com Reviewed-by: Brett Creeley brett.creeley@amd.com Link: https://patch.msgid.link/20250912141426.3922545-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c index 92f30ff2d6316..2d9efadb5d2ae 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c @@ -978,7 +978,7 @@ static int ionic_get_module_eeprom_by_page(struct net_device *netdev, { struct ionic_lif *lif = netdev_priv(netdev); struct ionic_dev *idev = &lif->ionic->idev; - u32 err = -EINVAL; + int err; u8 *src;
if (!page_data->length)