Re: [PATCH 3/7] pinctrl: armada-37xx: set GPIO output value before setting direction

On Mon, May 12, 2025 at 04:22:39PM +0200, Gabor Juhos wrote:

Changing the direction before updating the output value in the OUTPUT_VAL register may result in a glitch on the output line if the previous value in the OUTPUT_VAL register is different from the one we want to set.

In order to avoid that, update the output value before changing the direction.

Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Gabor Juhos j4g8y7@gmail.com Signed-off-by: Imre Kaloz kaloz@openwrt.org

Reviewed-by: Andrew Lunn andrew@lunn.ch

Andrew