Re: [PATCH] btrfs: scrub: reject unsupported scrub flags

On Thu, Apr 06, 2023 at 01:00:34PM +0800, Qu Wenruo wrote:

Since the introduction of scrub interface, the only flag that we support is BTRFS_SCRUB_READONLY.

Thus there is no sanity checks, if there are some undefined flags passed in, we just ignore them.

This is problematic if we want to introduce new scrub flags, as we have no way to determine if such flags are supported.

Thus this patch would address the problem by introducing a check for the flags, and if unsupported flags are set, return -EOPNOTSUPP to inform the user space.

This check should be backported for all supported kernels before any new scrub flags are introduced.

CC: stable@vger.kernel.org Signed-off-by: Qu Wenruo wqu@suse.com

Added to misc-next, thanks.