On 1/2/26 12:36 PM, Krishna Chaitanya Chundru wrote:
On 1/2/2026 5:04 PM, Konrad Dybcio wrote:
On 1/2/26 10:43 AM, Krishna Chaitanya Chundru wrote:
With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend.
Isn't turning the GDSCs off what we want though? At least during system suspend?
If we are keeping link in D3cold it makes sense, but currently we are not keeping in D3cold so we don't expect them to get off.
Since we seem to be tackling that in parallel, it seems to make sense that adding a mechanism to let the PCIe driver select "on" vs "ret" vs "off" could be useful for us
FWIW I recall I could turn off the GDSCs on at least makena with the old suspend patches and the controllers would come back to life afterwards
Konrad