On 10/10/2024 13:44, Johan Hovold wrote:
On Thu, Oct 10, 2024 at 01:55:11PM +0300, Dmitry Baryshkov wrote:
On Thu, 10 Oct 2024 at 13:11, Johan Hovold johan@kernel.org wrote:
On Thu, Oct 10, 2024 at 12:55:48PM +0300, Dmitry Baryshkov wrote:
Please don't break what is working. pd_mapper is working on all previous platforms. I suggest reverting commit bd6db1f1486e ("soc: qcom: pd_mapper: Add X1E80100") instead.
As I tried to explain in the commit message, there is currently nothing indicating that these issues are specific to x1e80100 (even if you may not hit them in your setup depending on things like probe order).
I have the understanding that the issues are related to the ADSP switching the firmware on the fly, which is only used on X1E8.
Is this speculation on your part or something that has recently been confirmed to be the case? AFAIK, there is nothing SoC specific about the ECANCELED issue, and we also still do not know what is causing the audio regression.
The thing is, we have a working and well-tested solution in the user-space service so there is no rush to switch to the in-kernel one (and risk distros removing the user-space service) before this has been fixed.
The in-kernel pd-mapper works fine on SM8550 and SM8650, please just revert the X1E8 patch as suggested by Dmitry.
Neil
Johan