Re: [PATCH v2 0/4] ASoC: qcom: sdw: fix memory leak

Hi Srini,

On Wed, Oct 22, 2025 at 4:52 AM Srinivas Kandagatla srinivas.kandagatla@oss.qualcomm.com wrote:

On 10/22/25 1:34 AM, Steev Klimaszewski wrote:

...

Hi Srini,

On the Thinkpad X13s, with this patchset applied, we end up seeing a NULL pointer dereference:

Thanks Steev, I think I know the issue, There was a silly typo in 3/4 patch. Could you please try this change, I will send this in v3 anyway;

-------------------------->cut<------------------------ diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c index 16bf09db29f5..6576b47a4c8c 100644 --- a/sound/soc/qcom/sdw.c +++ b/sound/soc/qcom/sdw.c @@ -31,6 +31,7 @@ static bool qcom_snd_is_sdw_dai(int id) case RX_CODEC_DMA_RX_6: case RX_CODEC_DMA_RX_7: case SLIMBUS_0_RX...SLIMBUS_6_TX:

•           return true;
    default:
            break;
    }
  
  

-------------------------->cut<------------------------

thanks, Srini>

Yep, that does it :) Thanks for the quick fix.

Tested-by: Steev Klimaszewski threeway@gmail.com # Thinkpad X13s

-- steev