-----Original Message----- From: Jakub Kicinski kuba@kernel.org Sent: Friday, March 7, 2025 10:50 PM To: Haiyang Zhang haiyangz@microsoft.com Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; Dexuan Cui decui@microsoft.com; stephen@networkplumber.org; KY Srinivasan kys@microsoft.com; Paul Rosswurm paulros@microsoft.com; olaf@aepfle.de; vkuznets@redhat.com; davem@davemloft.net; wei.liu@kernel.org; edumazet@google.com; pabeni@redhat.com; leon@kernel.org; Long Li longli@microsoft.com; ssengar@linux.microsoft.com; linux-rdma@vger.kernel.org; daniel@iogearbox.net; john.fastabend@gmail.com; bpf@vger.kernel.org; ast@kernel.org; hawk@kernel.org; tglx@linutronix.de; shradhagupta@linux.microsoft.com; linux-kernel@vger.kernel.org; stable@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH net] net: mana: Support holes in device list reply msg
On Wed, 5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
- for (i = 0; i < max_num_devs; i++) {
- for (i = 0; i < GDMA_DEV_LIST_SIZE &&
found_dev < resp.num_of_devs; i++) {unfortunate mis-indent here, it blend with the code. checkpatch is right that it should be aligned with opening bracket
Will fix it.
dev = resp.devs[i]; dev_type = dev.type;
/* Skip empty devices */if (dev.as_uint32 == 0)continue;found_dev++;dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,dev.type, dev.instance);Are you sure you want to print this info message for each device, each time it's probed? Seems pretty noisy. We generally recommend printing about _unusual_ things.
Ok. I can remove it.
Thanks, - Haiyang