On 6/20/2018 12:29 PM, Dennis Dalessandro wrote:
From: Michael J. Ruhl michael.j.ruhl@intel.com
The __get_txreq() function can return a pointer, ERR_PTR(-EBUSY), or NULL. All of the relevant call sites look for IS_ERR, so the NULL return would lead to a NULL pointer exception.
Do not use the ERR_PTR mechanism for this function.
Update all call sites to handle the return value correctly.
Clean up error paths to reflect return value.
cc: stable@vger.kernel.org # 4.9.x+ Reported-by: Dan Carpenter dan.carpenter@oracle.com Reviewed-by: Mike Marciniszyn mike.marciniszyn@intel.com Reviewed-by: Kamenee Arumugam kamenee.arumugam@intel.com Signed-off-by: Michael J. Ruhl michael.j.ruhl@intel.com Signed-off-by: Dennis Dalessandro dennis.dalessandro@intel.com
Fixes: 45842abbb292 ("staging/rdma/hfi1: move txreq header code")
-Denny