On Wed, 2019-03-27 at 09:46 -0700, Bart Van Assche wrote:
On Wed, 2019-03-27 at 12:11 -0400, Martin K. Petersen wrote:
Commit a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple of physical block size") split one conditional into several separate statements in an effort to provide more accurate warning messages when a device reports a nonsensical value. However, this reorganization accidentally dropped the precondition of the reported value being larger than zero. This lead to a warning getting emitted on devices that do not report an optimal I/O size at all.
Remain silent if a device does not report an optimal I/O size.
Fixes: a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple of physical block size") Reported-by: Hussam Al-Tayeb ht990332@gmx.com Cc: Randy Dunlap rdunlap@infradead.org Cc: stable@vger.kernel.org Signed-off-by: Martin K. Petersen martin.petersen@oracle.com
Reviewed-by: Bart Van Assche bvanassche@acm.org
I tested two SATA disks and three usb flash drives on two machines. The warnings are gone. Thank you very much for the patch.