Re: [PATCH 5.10 backport] io_uring: fix xa_alloc_cycle() error return value check

On Tue, Aug 24, 2021 at 01:15:01PM +0100, Pavel Begunkov wrote:

From: Jens Axboe axboe@kernel.dk

[ upstream commit a30f895ad3239f45012e860d4f94c1a388b36d14 ]

We currently check for ret != 0 to indicate error, but '1' is a valid return and just indicates that the allocation succeeded with a wrap. Correct the check to be for < 0, like it was before the xarray conversion.

Cc: stable@vger.kernel.org Fixes: 61cf93700fe6 ("io_uring: Convert personality_idr to XArray") Signed-off-by: Jens Axboe axboe@kernel.dk Signed-off-by: Pavel Begunkov asml.silence@gmail.com

Queued up, thanks!