On Tue, 12 Sept 2023 at 16:02, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Tue, Sep 12, 2023 at 02:19:34PM +0530, Naresh Kamboju wrote:
On Tue, 12 Sept 2023 at 07:55, Daniel Díaz daniel.diaz@linaro.org wrote:
Hello!
On Mon, 11 Sept 2023 at 14:58, Daniel Díaz daniel.diaz@linaro.org wrote:
On 11/09/23 7:40 a. m., Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 6.1.53 release. There are 600 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 13 Sep 2023 13:44:56 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.53-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below.
thanks,
greg k-h
We're seeing this new warning: -----8<----- /builds/linux/fs/udf/inode.c:892:6: warning: variable 'newblock' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 892 | if (*err < 0) | ^~~~~~~~ /builds/linux/fs/udf/inode.c:914:9: note: uninitialized use occurs here 914 | return newblock; | ^~~~~~~~ /builds/linux/fs/udf/inode.c:892:2: note: remove the 'if' if its condition is always false 892 | if (*err < 0) | ^~~~~~~~~~~~~ 893 | goto out_free; | ~~~~~~~~~~~~~ /builds/linux/fs/udf/inode.c:699:34: note: initialize the variable 'newblock' to silence this warning 699 | udf_pblk_t newblocknum, newblock; | ^ | = 0 1 warning generated. ----->8-----
That's with Clang 17 (and nightly) on:
- arm
- powerpc
- s390
For what it's worth, bisection points to 903b487b5ba6 ("udf: Handle error when adding extent to a file").
I see the following commit is fixing the reported problem.
commit 6d5ab7c2f7cf90877dab8f2bb06eb5ca8edc73ef Author: Tom Rix trix@redhat.com Date: Fri Dec 30 12:53:41 2022 -0500
udf: initialize newblock to 0 The clang build reports this error fs/udf/inode.c:805:6: error: variable 'newblock' is useduninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (*err < 0) ^~~~~~~~ newblock is never set before error handling jump. Initialize newblock to 0 and remove redundant settings.
Fixes: d8b39db5fab8 ("udf: Handle error when adding extent to a file") Reported-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Jan Kara <jack@suse.cz> Message-Id: <20221230175341.1629734-1-trix@redhat.com>Wait, where is this commit? I don't see it in Linus's tree either, nor in linux-next. Where did you find it?
Can you find this commit id ?
Commit id: 23970a1c9475b305770fd37bebfec7a10f263787 subject: ("udf: initialize newblock to 0")
- Naresh
confused,
greg k-h