Re: [PATCH v2 1/2] can: m_can: tcan4x5x: put the device out of standby before register access

On 02/01/2020 16.46, Marc Kleine-Budde wrote:

On 12/9/19 8:24 PM, Sean Nyekjaer wrote:

...

The m_can tries to detect of niso (canfd) is available while in standby, this function results in the following error:

tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized.

Can you add the missing error handling to m_can_config_endisable(), and handle this error correctly in all its callers?

Marc

Hi Marc

Sorry if this was a bit of mess :) Version 6 of this patch is already applied.... https://www.spinics.net/lists/linux-can/msg03186.html

Do you want me to add more error handling than this?

/Sean