There is a configuration dependency issue in the original 5.10.y, CONFIG_SCSI_LPFC should rely on CONFIG_IRQ_POLL. So it is needed to enable CONFIG_IRQ_POLL also when building the changed source code. Otherwise you get a link error: ld: drivers/scsi/lpfc/lpfc_sli.o: in function `__lpfc_sli4_process_cq': lpfc_sli.c:(.text+0x37b6): undefined reference to `irq_poll_complete' ld: drivers/scsi/lpfc/lpfc_sli.o: in function `lpfc_sli4_process_eq': lpfc_sli.c:(.text+0x41b1): undefined reference to `irq_poll_sched' ld: drivers/scsi/lpfc/lpfc_sli.o: in function `lpfc_cq_create': lpfc_sli.c:(.text+0x1281f): undefined reference to `irq_poll_init'
--
Bin Lan
On 4/3/2025 11:29 AM, bin.lan.cn@windriver.com wrote:
From: Tuo Li islituo@gmail.com
[ Upstream commit 0e881c0a4b6146b7e856735226208f48251facd8 ]
The variable phba->fcf.fcf_flag is often protected by the lock phba->hbalock() when is accessed. Here is an example in lpfc_unregister_fcf_rescan():
spin_lock_irq(&phba->hbalock); phba->fcf.fcf_flag |= FCF_INIT_DISC; spin_unlock_irq(&phba->hbalock);
However, in the same function, phba->fcf.fcf_flag is assigned with 0 without holding the lock, and thus can cause a data race:
phba->fcf.fcf_flag = 0;
To fix this possible data race, a lock and unlock pair is added when accessing the variable phba->fcf.fcf_flag.
Reported-by: BassCheck bass@buaa.edu.cn Signed-off-by: Tuo Li islituo@gmail.com Link: https://lore.kernel.org/r/20230630024748.1035993-1-islituo@gmail.com Reviewed-by: Justin Tee justin.tee@broadcom.com Reviewed-by: Laurence Oberman loberman@redhat.com Signed-off-by: Martin K. Petersen martin.petersen@oracle.com Signed-off-by: Bin Lan bin.lan.cn@windriver.com Signed-off-by: He Zhe zhe.he@windriver.com
Build test passed.
drivers/scsi/lpfc/lpfc_hbadisc.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 68ff233f936e..3ff76ca147a5 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -6790,7 +6790,9 @@ lpfc_unregister_fcf_rescan(struct lpfc_hba *phba) if (rc) return; /* Reset HBA FCF states after successful unregister FCF */
- spin_lock_irq(&phba->hbalock); phba->fcf.fcf_flag = 0;
- spin_unlock_irq(&phba->hbalock); phba->fcf.current_rec.flag = 0;
/*