+Cc: Ioana
On Wed, Dec 03, 2025 at 10:03:42AM +0800, Wentao Guan wrote:
Because gpiochip_add_data successfully done, use
gpiochip_add_data()
err_remove_gpiochip instead of err_free_bitmap to free such as gdev,descs..
What does 'gdev,desc.' stand for (also notice dot at the end)?
Fixes: 553b75d4bfe9 ("gpio: regmap: Allow to allocate regmap-irq device")
Perhaps you also want to add this ae495810cffe ("gpio: regmap: add the .fixed_direction_output configuration parameter")
As the patch changed the logic from the original commit.
Interestingly the 3bd44edd6c55 ("gpio: regmap: fix memory leak of gpio_regmap structure") fixed one leak and missed this one.
...
struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
config->regmap_irq_line, config->regmap_irq_flags, 0, config->regmap_irq_chip, &gpio->irq_chip_data); if (ret)
goto err_free_bitmap;
goto err_remove_gpiochip;irq_domain = regmap_irq_get_domain(gpio->irq_chip_data); } else