On Thu, Dec 26, 2019 at 12:55 AM Sasha Levin sashal@kernel.org wrote:

This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.4.5, v5.3.18, v4.19.90, v4.14.159, v4.9.206, v4.4.206.

v5.4.5: Build OK! v5.3.18: Build OK! v4.19.90: Build OK! v4.14.159: Failed to apply! Possible dependencies: 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") fef6cc6b3618 ("media: v4l2-compat-ioctl32: fix several __user annotations")

v4.9.206: Failed to apply! Possible dependencies: 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") a56bc171598c ("[media] v4l: compat: Prevent allocating excessive amounts of memory") ba7ed691dcce ("[media] v4l2-compat-ioctl32: VIDIOC_S_EDID should return all fields on error") fb9ffa6a7f7e ("[media] v4l: Add metadata buffer type and format") fef6cc6b3618 ("media: v4l2-compat-ioctl32: fix several __user annotations")

v4.4.206: Failed to apply! Possible dependencies: 0579e6e3a326 ("doc-rst: linux_tv: remove whitespaces") 17defc282fe6 ("Documentation: add meta-documentation for Sphinx and kernel-doc") 22cba31bae9d ("Documentation/sphinx: add basic working Sphinx configuration and build") 234d549662a7 ("doc-rst: video: use reference for VIDIOC_ENUMINPUT") 5377d91f3e88 ("doc-rst: linux_tv DocBook to reST migration (docs-next)") 6dd0394f5fcd ("media: v4l2-compat-ioctl32: better name userspace pointers") 7347081e8a52 ("doc-rst: linux_tv: simplify references") 789818845202 ("doc-rst: audio: Fix some cross references") 94fff0dc5333 ("doc-rst: dmx_fcalls: improve man-like format") 9e00ffca8cc7 ("doc-rst: querycap: fix troubles on some references") af4a4d0db8ab ("doc-rst: linux_tv: Replace reference names to match ioctls") c2b66cafdf02 ("[media] v4l: doc: Remove row numbers from tables") e6702ee18e24 ("doc-rst: app-pri: Fix a bad reference") fb9ffa6a7f7e ("[media] v4l: Add metadata buffer type and format")

NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

I think we need it to support users of musl on old kernels: musl is adding conversion functions for emulating the new (time64) ioctl commands on top of the old format, and without my patch, the new commands do not necessarily return an error that musl can catch.

I can provide a backport of my patch to v4.4 and v4.9 for this when the patch has made it into mainline. Can you notify me again when the time has come?

A related question that we should address is whether we want the v4l2 and alsa time64 ioctl patches backported as well, and to which kernels (if any).

My feeling is that we don't want them those in v4.14 and earlier because that is rather pointless with musl already having emulation in user space and the rest of the kernel not being y2038 safe at all. For v5.4 I'd say we do want them, and possibly all the other remaining y2038 patches as well, I have a tree[1] that I try to keep up to date with the versions that got posted and/or merged, as I know there is demand for it. If you prefer not to have them in v5.4.y, I can keep them here myself and make sure it's possible to my branch into that instead.

v4.19 is a bit borderline: if we decide to do the backports to v5.4 and there is demand for v4.19.y, I could also try to pick the most important patches from my tree and backport them to v4.19.0 (including a lot of work that went into v5.1) and then look at that tree to see if it should be part of the official v4.19.y or not.

Arnd

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=y...