On 7/10/24 10:41, Tvrtko Ursulin wrote:

From: Tvrtko Ursulin tvrtko.ursulin@igalia.com

If userspace provides an unknown or invalid handle anywhere in the handle array the rest of the driver will not handle that well.

Fix it by checking handle was looked up successfuly or otherwise fail the extension by jumping into the existing unwind.

Signed-off-by: Tvrtko Ursulin tvrtko.ursulin@igalia.com Fixes: bae7cb5d6800 ("drm/v3d: Create a CPU job extension for the reset performance query job" Cc: Maíra Canal mcanal@igalia.com Cc: Iago Toral Quiroga itoral@igalia.com Cc: stable@vger.kernel.org # v6.8+

---

drivers/gpu/drm/v3d/v3d_submit.c | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/v3d/v3d_submit.c b/drivers/gpu/drm/v3d/v3d_submit.c index 3313423080e7..b51600e236c8 100644 --- a/drivers/gpu/drm/v3d/v3d_submit.c +++ b/drivers/gpu/drm/v3d/v3d_submit.c @@ -706,6 +706,10 @@ v3d_get_cpu_reset_performance_params(struct drm_file *file_priv, } job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);

• if (!job->performance_query.queries[i].syncobj) {
  

• 	err = -ENOENT;
  

Same from previous patch.

Best Regards, - Maíra

• 	goto error;
  

• }
  

  } job->performance_query.count = reset.count; job->performance_query.nperfmons = reset.nperfmons;

@@ -787,6 +791,10 @@ v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv, } job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);

• if (!job->performance_query.queries[i].syncobj) {
  

• 	err = -ENOENT;
  

• 	goto error;
  

• }
  

  } job->performance_query.count = copy.count; job->performance_query.nperfmons = copy.nperfmons;