stable-rc: queue: v5.15: drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__free'
The arm queues build gcc-12 defconfig-lkftconfig failed on the Linux stable-rc queue 5.15 for the arm architectures.
arm * arm, build - build/gcc-12-defconfig-lkftconfig
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build errors: ------ drivers/clocksource/timer-ti-dm-systimer.c: In function 'dmtimer_percpu_quirk_init': drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__free' 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: implicit declaration of function '__free'; did you mean 'kfree'? [-Werror=implicit-function-declaration] 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ | kfree drivers/clocksource/timer-ti-dm-systimer.c:691:46: error: 'device_node' undeclared (first use in this function) 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:46: note: each undeclared identifier is reported only once for each function it appears in drivers/clocksource/timer-ti-dm-systimer.c:694:36: error: 'arm_timer' undeclared (first use in this function); did you mean 'add_timer'? 694 | if (of_device_is_available(arm_timer)) { | ^~~~~~~~~ | add_timer cc1: some warnings being treated as errors
Links: --- - https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.15/build/v... - https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.15/build/v... - https://qa-reports.linaro.org/lkft/linux-stable-rc-queues-queue_5.15/build/v...
Steps to reproduce: ------------ - tuxmake \ --runtime podman \ --target-arch arm \ --toolchain gcc-12 \ --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2pfZrBARu3w5Sf8rdEqEy...
metadata: ---- git describe: v5.15.173-312-gc83ccef4e8ee git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git sha: c83ccef4e8ee73e988561f85f18d2d73c7626ad0 kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2pfZrBARu3w5Sf8rdEqEy... build url: https://storage.tuxsuite.com/public/linaro/lkft/builds/2pfZrBARu3w5Sf8rdEqEy... toolchain: gcc-12 config: gcc-12-defconfig-lkftconfig arch: arm
-- Linaro LKFT https://lkft.linaro.org
On 02/12/2024 19:43, Naresh Kamboju wrote:
The arm queues build gcc-12 defconfig-lkftconfig failed on the Linux stable-rc queue 5.15 for the arm architectures.
arm
- arm, build
- build/gcc-12-defconfig-lkftconfig
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build errors:
drivers/clocksource/timer-ti-dm-systimer.c: In function 'dmtimer_percpu_quirk_init': drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__free' 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: implicit declaration of function '__free'; did you mean 'kfree'? [-Werror=implicit-function-declaration] 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ | kfree drivers/clocksource/timer-ti-dm-systimer.c:691:46: error: 'device_node' undeclared (first use in this function) 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:46: note: each undeclared identifier is reported only once for each function it appears in drivers/clocksource/timer-ti-dm-systimer.c:694:36: error: 'arm_timer' undeclared (first use in this function); did you mean 'add_timer'? 694 | if (of_device_is_available(arm_timer)) { | ^~~~~~~~~ | add_timer cc1: some warnings being treated as errors
The __free() macro is defined in include/linux/cleanup.h, and that header does not exist in v5.15. It was introduced with v6.1, and older kernels can't profit from it.
That means that this patch does not apply in its current form for v5.15. If someone wants to backport it, calls to of_node_put() have to be added to the early returns.
Best regards, Javier Carrasco
On Mon, Dec 02, 2024 at 08:08:07PM +0100, Javier Carrasco wrote:
On 02/12/2024 19:43, Naresh Kamboju wrote:
The arm queues build gcc-12 defconfig-lkftconfig failed on the Linux stable-rc queue 5.15 for the arm architectures.
arm
- arm, build
- build/gcc-12-defconfig-lkftconfig
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build errors:
drivers/clocksource/timer-ti-dm-systimer.c: In function 'dmtimer_percpu_quirk_init': drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__free' 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: implicit declaration of function '__free'; did you mean 'kfree'? [-Werror=implicit-function-declaration] 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~ | kfree drivers/clocksource/timer-ti-dm-systimer.c:691:46: error: 'device_node' undeclared (first use in this function) 691 | struct device_node *arm_timer __free(device_node) = | ^~~~~~~~~~~ drivers/clocksource/timer-ti-dm-systimer.c:691:46: note: each undeclared identifier is reported only once for each function it appears in drivers/clocksource/timer-ti-dm-systimer.c:694:36: error: 'arm_timer' undeclared (first use in this function); did you mean 'add_timer'? 694 | if (of_device_is_available(arm_timer)) { | ^~~~~~~~~ | add_timer cc1: some warnings being treated as errors
The __free() macro is defined in include/linux/cleanup.h, and that header does not exist in v5.15. It was introduced with v6.1, and older kernels can't profit from it.
That means that this patch does not apply in its current form for v5.15. If someone wants to backport it, calls to of_node_put() have to be added to the early returns.
Now dropped, thanks.
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg Kroah-Hartman -
Javier Carrasco -
Naresh Kamboju