Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
*CAUTION: External Email *
6.5-stable review patch. If anyone has any objections, please let me know.
From: Max Nguyen maxwell.nguyen@hp.com
commit e28a0974d749e5105d77233c0a84d35c37da047e upstream.
Add HyperX controller support to xpad_device and xpad_table.
Suggested-by: Chris Toledanes chris.toledanes@hp.com Reviewed-by: Carl Ng carl.ng@hp.com Signed-off-by: Max Nguyen maxwell.nguyen@hp.com Reviewed-by: Rahul Rameshbabu rrameshbabu@nvidia.com Link: https://lore.kernel.org/r/20230906231514.4291-1-hphyperxdev@gmail.com Signed-off-by: Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
drivers/input/joystick/xpad.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -130,6 +130,7 @@ static const struct xpad_device { { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 }, { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 }, { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 },
- { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },
{ 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX }, { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX }, { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX }, @@ -458,6 +459,7 @@ static const struct usb_device_id xpad_t { USB_INTERFACE_INFO('X', 'B', 0) }, /* Xbox USB-IF not-approved class */ XPAD_XBOX360_VENDOR(0x0079), /* GPD Win 2 controller */ XPAD_XBOX360_VENDOR(0x03eb), /* Wooting Keyboards (Legacy) */
- XPAD_XBOXONE_VENDOR(0x03f0), /* HP HyperX Xbox One controllers */
XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster Xbox 360 controllers */ XPAD_XBOX360_VENDOR(0x045e), /* Microsoft Xbox 360 controllers */ XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft Xbox One controllers */
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
On 11/21/2023 10:39 PM, Greg KH wrote:
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
Hi,
We would like to apply this patch to version 6.1 of the LTS branch. This is to add a project ID for Android support for a gamepad controller. We would like it to apply sooner than waiting for the next LTS branch due to project schedules.
commite28a0974d749e5105d77233c0a84d35c37da047e
Regards,
Max
Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
Hi Greg,
I am planning to send a patch for LTS versions 4.19 through 5.15 since the single patch can apply to all of these versions with no issues. I plan to send a separate patch for LTS 6.1 since this patch could not apply to the older LTS versions.
Is this what you had in mind when you mentioned series?
On 11/22/2023 2:18 PM, Nguyen, Max wrote:
On 11/21/2023 10:39 PM, Greg KH wrote:
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote:
> Hi, > > We would like to apply this patch to version 6.1 of the LTS branch. > This is to add a project ID for Android support for a gamepad > controller. We would like it to apply sooner than waiting > for the next > LTS branch due to project schedules. > > commite28a0974d749e5105d77233c0a84d35c37da047e > > Regards, > > Max > Hi Linux team,
We would like to have this patch backported to LTS versions 4.19, 5.4, 5.10, and 5.15 as well. The main purpose would to add our device ID for support across older android devices. Feel free to let us know if there are any concerns or issues.
Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
Hi Greg,
I am planning to send a patch for LTS versions 4.19 through 5.15 since the single patch can apply to all of these versions with no issues. I plan to send a separate patch for LTS 6.1 since this patch could not apply to the older LTS versions.
Is this what you had in mind when you mentioned series?
I resent the patches as a series as described in the patch submission process on the kernel webpage. I reviewed and believe it should be formatted correctly now. Let me know if there are any issues.
On Wed, Nov 22, 2023 at 03:10:39PM -0800, Nguyen, Max wrote:
On 11/22/2023 2:18 PM, Nguyen, Max wrote:
On 11/21/2023 10:39 PM, Greg KH wrote:
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote:
On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote: > > Hi, > > > > We would like to apply this patch to version 6.1 of the LTS branch. > > This is to add a project ID for Android support for a gamepad > > controller. We would like it to apply sooner than waiting > > for the next > > LTS branch due to project schedules. > > > > commite28a0974d749e5105d77233c0a84d35c37da047e > > > > Regards, > > > > Max > > > Hi Linux team, > > We would like to have this patch backported to LTS versions > 4.19, 5.4, 5.10, > and 5.15 as well. The main purpose would to add our device ID > for support > across older android devices. Feel free to let us know if there > are any > concerns or issues. Please provide a working backport that you have tested as I think it did not apply cleanly on its own, right?
thanks,
greg k-h
Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
Hi Greg,
I am planning to send a patch for LTS versions 4.19 through 5.15 since the single patch can apply to all of these versions with no issues. I plan to send a separate patch for LTS 6.1 since this patch could not apply to the older LTS versions.
Is this what you had in mind when you mentioned series?
I resent the patches as a series as described in the patch submission process on the kernel webpage. I reviewed and believe it should be formatted correctly now. Let me know if there are any issues.
No, I mean, for each stable kernel version/tree/whatever, send a patch series that adds all of the missing ids to the table, not just your one specific device you are asking for here. That way the trees are all in sync proper AND any future patches will also apply cleanly/properly to the older kernel versions.
Does that help?
thanks,
greg k-h
On 11/23/2023 12:59 AM, Greg KH wrote:
On Wed, Nov 22, 2023 at 03:10:39PM -0800, Nguyen, Max wrote:
On 11/22/2023 2:18 PM, Nguyen, Max wrote:
On 11/21/2023 10:39 PM, Greg KH wrote:
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote:
On 11/18/2023 3:32 AM, Greg KH wrote: > On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote: >>> Hi, >>> >>> We would like to apply this patch to version 6.1 of the LTS branch. >>> This is to add a project ID for Android support for a gamepad >>> controller. We would like it to apply sooner than waiting >>> for the next >>> LTS branch due to project schedules. >>> >>> commite28a0974d749e5105d77233c0a84d35c37da047e >>> >>> Regards, >>> >>> Max >>> >> Hi Linux team, >> >> We would like to have this patch backported to LTS versions >> 4.19, 5.4, 5.10, >> and 5.15 as well. The main purpose would to add our device ID >> for support >> across older android devices. Feel free to let us know if there >> are any >> concerns or issues. > Please provide a working backport that you have tested > as I think it did > not apply cleanly on its own, right? > > thanks, > > greg k-h Hi Greg,
Do you have any general suggestions or instructions on how I can create a backport to test? I apologize as this is new to me.
Also, what do you mean by the patch did not apply cleanly on its own?
We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
Hi Greg,
I am planning to send a patch for LTS versions 4.19 through 5.15 since the single patch can apply to all of these versions with no issues. I plan to send a separate patch for LTS 6.1 since this patch could not apply to the older LTS versions.
Is this what you had in mind when you mentioned series?
I resent the patches as a series as described in the patch submission process on the kernel webpage. I reviewed and believe it should be formatted correctly now. Let me know if there are any issues.
No, I mean, for each stable kernel version/tree/whatever, send a patch series that adds all of the missing ids to the table, not just your one specific device you are asking for here. That way the trees are all in sync proper AND any future patches will also apply cleanly/properly to the older kernel versions.
Does that help?
thanks,
greg k-h
Hi Greg,
We only have 1 device for now as our other devices should not be known to public yet. Do you mean missing IDs for other company/brand's devices? We are unsure of the other device's compatibility requirements as they are not ours.
I sent a 2 series patch for the different stable kernel versions. Does my latest patch submission work or should I be sending a patch for each individual stable kernel version?
On Tue, Nov 28, 2023 at 03:37:30PM -0800, Nguyen, Max wrote:
On 11/23/2023 12:59 AM, Greg KH wrote:
On Wed, Nov 22, 2023 at 03:10:39PM -0800, Nguyen, Max wrote:
On 11/22/2023 2:18 PM, Nguyen, Max wrote:
On 11/21/2023 10:39 PM, Greg KH wrote:
On Tue, Nov 21, 2023 at 04:17:54PM -0800, Nguyen, Max wrote:
On 11/20/2023 3:52 PM, Nguyen, Max wrote: > On 11/18/2023 3:32 AM, Greg KH wrote: > > On Fri, Nov 17, 2023 at 03:42:22PM -0800, Nguyen, Max wrote: > > > > Hi, > > > > > > > > We would like to apply this patch to version 6.1 of the LTS branch. > > > > This is to add a project ID for Android support for a gamepad > > > > controller. We would like it to apply sooner than waiting > > > > for the next > > > > LTS branch due to project schedules. > > > > > > > > commite28a0974d749e5105d77233c0a84d35c37da047e > > > > > > > > Regards, > > > > > > > > Max > > > > > > > Hi Linux team, > > > > > > We would like to have this patch backported to LTS versions > > > 4.19, 5.4, 5.10, > > > and 5.15 as well. The main purpose would to add our device ID > > > for support > > > across older android devices. Feel free to let us know if there > > > are any > > > concerns or issues. > > Please provide a working backport that you have tested > > as I think it did > > not apply cleanly on its own, right? > > > > thanks, > > > > greg k-h > Hi Greg, > > Do you have any general suggestions or instructions on how I > can create > a backport to test? I apologize as this is new to me. > > Also, what do you mean by the patch did not apply cleanly on its own? > We found that the patch does not apply correctly to the previous LTS kernels. This is most likely due to addition of newer devices over time. We will be sending separate patches for each kernel shortly.
Why not send a series adding all of the missing backported patches? That makes it better so that all of the supported devices are now working on the older kernels, not just this one.
thanks,
greg k-h
Hi Greg,
I am planning to send a patch for LTS versions 4.19 through 5.15 since the single patch can apply to all of these versions with no issues. I plan to send a separate patch for LTS 6.1 since this patch could not apply to the older LTS versions.
Is this what you had in mind when you mentioned series?
I resent the patches as a series as described in the patch submission process on the kernel webpage. I reviewed and believe it should be formatted correctly now. Let me know if there are any issues.
No, I mean, for each stable kernel version/tree/whatever, send a patch series that adds all of the missing ids to the table, not just your one specific device you are asking for here. That way the trees are all in sync proper AND any future patches will also apply cleanly/properly to the older kernel versions.
Does that help?
thanks,
greg k-h
Hi Greg,
We only have 1 device for now as our other devices should not be known to public yet. Do you mean missing IDs for other company/brand's devices?
No, I mean the missing git commits for the file you are touching that has the list of the devices in it. That is out of date and should be brought up to the latest version with the full list of devices, right?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Nguyen, Max