The l12b and l15b supplies are used by components that are not (fully) described (and some never will be) and must never be disabled.
Mark the regulators as always-on to prevent them from being disabled, for example, when consumers probe defer or suspend.
Note that these supplies currently have no consumers described in mainline.
Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") Cc: stable@vger.kernel.org # 6.13 Cc: Aleksandrs Vinarskis alex.vinarskis@gmail.com Signed-off-by: Johan Hovold johan+linaro@kernel.org --- arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index 86e87f03b0ec..90f588ed7d63 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -359,6 +359,7 @@ vreg_l12b_1p2: ldo12 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + regulator-always-on; };
vreg_l13b_3p0: ldo13 { @@ -380,6 +381,7 @@ vreg_l15b_1p8: ldo15 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + regulator-always-on; };
vreg_l17b_2p5: ldo17 {
On Thu, 27 Feb 2025 at 09:15, Johan Hovold johan+linaro@kernel.org wrote:
The l12b and l15b supplies are used by components that are not (fully) described (and some never will be) and must never be disabled.
Out of curiosity, what are these components?
Mark the regulators as always-on to prevent them from being disabled, for example, when consumers probe defer or suspend.
Note that these supplies currently have no consumers described in mainline.
Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") Cc: stable@vger.kernel.org # 6.13 Cc: Aleksandrs Vinarskis alex.vinarskis@gmail.com Signed-off-by: Johan Hovold johan+linaro@kernel.org
Reviewed-by: Aleksandrs Vinarskis alex.vinarskis@gmail.com Tested-by: Aleksandrs Vinarskis alex.vinarskis@gmail.com
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index 86e87f03b0ec..90f588ed7d63 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -359,6 +359,7 @@ vreg_l12b_1p2: ldo12 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-always-on; }; vreg_l13b_3p0: ldo13 {@@ -380,6 +381,7 @@ vreg_l15b_1p8: ldo15 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-always-on; }; vreg_l17b_2p5: ldo17 {-- 2.45.3
On 2.03.2025 11:04 PM, Aleksandrs Vinarskis wrote:
On Thu, 27 Feb 2025 at 09:15, Johan Hovold johan+linaro@kernel.org wrote:
The l12b and l15b supplies are used by components that are not (fully) described (and some never will be) and must never be disabled.
Out of curiosity, what are these components?
Mainly dumb onboard electronic components, it seems like
Konrad
On Sun, Mar 02, 2025 at 11:04:03PM +0100, Aleksandrs Vinarskis wrote:
On Thu, 27 Feb 2025 at 09:15, Johan Hovold johan+linaro@kernel.org wrote:
The l12b and l15b supplies are used by components that are not (fully) described (and some never will be) and must never be disabled.
Out of curiosity, what are these components?
A host of things, including pull-ups, level shifters, regulators for (partially) described devices, but also things like the speakers and wlan.
Mark the regulators as always-on to prevent them from being disabled, for example, when consumers probe defer or suspend.
Note that these supplies currently have no consumers described in mainline.
Johan
linux-stable-mirror@lists.linaro.org
-
Aleksandrs Vinarskis -
Johan Hovold -
Johan Hovold -
Konrad Dybcio