From: Mario Limonciello mario.limonciello@amd.com
Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.
Block the interrupt from getting set up for this GPIO on this device.
Cc: stable@vger.kernel.org Reported-and-tested-by: Delgan delgan.py@gmail.com Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954 Signed-off-by: Mario Limonciello mario.limonciello@amd.com --- drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 1f9fe50bba005..f7746c57ba76a 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1689,6 +1689,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { .ignore_wake = "PNP0C50:00@8", }, }, + { + /* + * Spurious wakeups from GPIO 11 + * Found in BIOS 1.04 + * https://gitlab.freedesktop.org/drm/amd/-/issues/3954 + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), + DMI_MATCH(DMI_PRODUCT_FAMILY, "Acer Nitro V 14"), + }, + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { + .ignore_interrupt = "AMDI0030:00@11", + }, + }, {} /* Terminating entry */ };
On Tue, Feb 11, 2025 at 02:32:01PM -0600, Mario Limonciello wrote:
From: Mario Limonciello mario.limonciello@amd.com
Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.
Block the interrupt from getting set up for this GPIO on this device.
Cc: stable@vger.kernel.org Reported-and-tested-by: Delgan delgan.py@gmail.com Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954 Signed-off-by: Mario Limonciello mario.limonciello@amd.com
Acked-by: Mika Westerberg westeri@kernel.org
On Tue, Feb 11, 2025 at 9:32 PM Mario Limonciello superm1@kernel.org wrote:
From: Mario Limonciello mario.limonciello@amd.com
Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.
Block the interrupt from getting set up for this GPIO on this device.
Cc: stable@vger.kernel.org Reported-and-tested-by: Delgan delgan.py@gmail.com
Please refer to process/submitting-patches.rst - don't combine tags.
This should be `Closes`, not `Close`.
I fixed the two above myself but please keep it in mind next time.
Bartosz
From: Bartosz Golaszewski bartosz.golaszewski@linaro.org
On Tue, 11 Feb 2025 14:32:01 -0600, Mario Limonciello wrote:
Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.
Block the interrupt from getting set up for this GPIO on this device.
[...]
Applied, thanks!
[1/1] gpiolib: acpi: Add a quirk for Acer Nitro ANV14 commit: 8743d66979e494c5378563e6b5a32e913380abd8
Best regards,
On Tue, Feb 11, 2025 at 02:32:01PM -0600, Mario Limonciello wrote:
From: Mario Limonciello mario.limonciello@amd.com
Spurious immediate wake up events are reported on Acer Nitro ANV14. GPIO 11 is specified as an edge triggered input and also a wake source but this pin is supposed to be an output pin for an LED, so it's effectively floating.
Block the interrupt from getting set up for this GPIO on this device.
Cc: stable@vger.kernel.org Reported-and-tested-by: Delgan delgan.py@gmail.com Close: https://gitlab.freedesktop.org/drm/amd/-/issues/3954
Closes:
Otherwise, Acked-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
linux-stable-mirror@lists.linaro.org