Re: Patch "net: move ethtool-related netdev state into its own struct" has been added to the 6.10-stable tree
On 05/08/2024 13:19, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
net: move ethtool-related netdev state into its own structto the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: net-move-ethtool-related-netdev-state-into-its-own-s.patch and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
This, and the series it's from, are absolutely not -stable material. The commits do not fix any existing bugs, they are in support of new features (netlink dumping of RSS contexts), and are a fairly large and complex set of changes, which have not even stabilised yet — we have already found issues both within the set and exposed by it in other code, which are being fixed for 6.11.
commit e331e73ff4c5c89a7f51a465ae40a7ad9fcd7a28 Author: Edward Cree ecree.xilinx@gmail.com Date: Thu Jun 27 16:33:46 2024 +0100
net: move ethtool-related netdev state into its own struct[ Upstream commit 3ebbd9f6de7ec6d538639ebb657246f629ace81e ] net_dev->ethtool is a pointer to new struct ethtool_netdev_state, which currently contains only the wol_enabled field. Suggested-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Edward Cree ecree.xilinx@gmail.com Reviewed-by: Przemek Kitszel przemyslaw.kitszel@intel.com Link: https://patch.msgid.link/293a562278371de7534ed1eb17531838ca090633.1719502239... Signed-off-by: Jakub Kicinski kuba@kernel.org Stable-dep-of: 7195f0ef7f5b ("ethtool: fix setting key and resetting indir at once") Signed-off-by: Sasha Levin sashal@kernel.org
As far as I can tell, 7195f0ef7f5b should backport fairly cleanly to 6.10 with only simple textual fuzz. It should not be necessary to backport the "ethtool: track custom RSS contexts in the core" series to support this.
The above NAK also applies to the backports of: net-ethtool-attach-an-xarray-of-custom-rss-contexts-.patch net-ethtool-record-custom-rss-contexts-in-the-xarray.patch net-ethtool-add-a-mutex-protecting-rss-contexts.patch which were notified at the same time.
-ed
On Mon, Aug 05, 2024 at 01:45:18PM +0100, Edward Cree wrote:
On 05/08/2024 13:19, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
net: move ethtool-related netdev state into its own structto the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: net-move-ethtool-related-netdev-state-into-its-own-s.patch and it can be found in the queue-6.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
This, and the series it's from, are absolutely not -stable material. The commits do not fix any existing bugs, they are in support of new features (netlink dumping of RSS contexts), and are a fairly large and complex set of changes, which have not even stabilised yet — we have already found issues both within the set and exposed by it in other code, which are being fixed for 6.11.
commit e331e73ff4c5c89a7f51a465ae40a7ad9fcd7a28 Author: Edward Cree ecree.xilinx@gmail.com Date: Thu Jun 27 16:33:46 2024 +0100
net: move ethtool-related netdev state into its own struct [ Upstream commit 3ebbd9f6de7ec6d538639ebb657246f629ace81e ] net_dev->ethtool is a pointer to new struct ethtool_netdev_state, which currently contains only the wol_enabled field. Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Link: https://patch.msgid.link/293a562278371de7534ed1eb17531838ca090633.1719502239.git.ecree.xilinx@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Stable-dep-of: 7195f0ef7f5b ("ethtool: fix setting key and resetting indir at once") Signed-off-by: Sasha Levin <sashal@kernel.org>As far as I can tell, 7195f0ef7f5b should backport fairly cleanly to 6.10 with only simple textual fuzz. It should not be necessary to backport the "ethtool: track custom RSS contexts in the core" series to support this.
The above NAK also applies to the backports of: net-ethtool-attach-an-xarray-of-custom-rss-contexts-.patch net-ethtool-record-custom-rss-contexts-in-the-xarray.patch net-ethtool-add-a-mutex-protecting-rss-contexts.patch which were notified at the same time.
Makes sense! I've modified the backport of 7195f0ef7f5b ("ethtool: fix setting key and resetting indir at once") as proposed.
linux-stable-mirror@lists.linaro.org
-
Edward Cree -
Sasha Levin