As kcalloc() may fail, check its return value to avoid a NULL pointer dereference when passing the buffer to rng->read() and print_hex_dump_debug().
Fixes: 2be0d806e25e ("crypto: caam - add a test for the RNG") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li lgs201920130244@gmail.com --- drivers/crypto/caam/caamrng.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/caam/caamrng.c b/drivers/crypto/caam/caamrng.c index e0adb326f496..d887ecf6f99d 100644 --- a/drivers/crypto/caam/caamrng.c +++ b/drivers/crypto/caam/caamrng.c @@ -183,7 +183,6 @@ static inline void test_len(struct hwrng *rng, size_t len, bool wait) buf = kcalloc(CAAM_RNG_MAX_FIFO_STORE_SIZE, sizeof(u8), GFP_KERNEL);
if (!buf) { - dev_err(dev, "RNG buffer allocation failed\n"); return; } while (len > 0) {
On Thu, Sep 18, 2025 at 06:15:27PM +0800, Guangshuo Li wrote:
As kcalloc() may fail, check its return value to avoid a NULL pointer dereference when passing the buffer to rng->read() and print_hex_dump_debug().
But that is not what this patch does :(
Fixes: 2be0d806e25e ("crypto: caam - add a test for the RNG") Cc: stable@vger.kernel.org
No need for stable here.
Signed-off-by: Guangshuo Li lgs201920130244@gmail.com
drivers/crypto/caam/caamrng.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/caam/caamrng.c b/drivers/crypto/caam/caamrng.c index e0adb326f496..d887ecf6f99d 100644 --- a/drivers/crypto/caam/caamrng.c +++ b/drivers/crypto/caam/caamrng.c @@ -183,7 +183,6 @@ static inline void test_len(struct hwrng *rng, size_t len, bool wait) buf = kcalloc(CAAM_RNG_MAX_FIFO_STORE_SIZE, sizeof(u8), GFP_KERNEL); if (!buf) {
dev_err(dev, "RNG buffer allocation failed\n");
checkpatch should show that you can remove the { } now, right?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Guangshuo Li