It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com ---
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, }, + { + .ident = "Dell XPS 15 L502X", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"), + }, + }, { } };
On Sat, Jan 23, 2021 at 06:46:08PM -0800, Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
Applied.
Thanks, Guenter
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),},- }, { }
};
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
And have you reported this issue to Dell support?
},- }, { }
}; -- 2.30.0
On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár pali@kernel.org wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
{.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
This is a good question. We didn't try the other list. Bob is the one with the affected system. Could you try moving the added block of code from i8k_blacklist_fan_support_dmi_table a few lines up to i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it remains fixed?
And have you reported this issue to Dell support?
},}, { }};
-- 2.30.0
(Apologies for the previous HTML copy of this reply, to those directly CCed.)
-Tom
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Thanks, Guenter
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Of course! We will just wait for Bob test results.
Thanks, Guenter
On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Of course! We will just wait for Bob test results.
Guenter, now we have all needed information, fix is really needed in this form. So you can add my:
Reviewed-by: Pali Rohár pali@kernel.org
On 1/27/21 3:00 PM, Pali Rohár wrote:
On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Of course! We will just wait for Bob test results.
Guenter, now we have all needed information, fix is really needed in this form. So you can add my:
Reviewed-by: Pali Rohár pali@kernel.org
Applied (again)
Thanks, Guenter
I've posted something on the Dell Community site as I can't get to the proper support pages (expired warranty).
https://www.dell.com/community/XPS/Linux-kernel-regression-in-fan-control-de...
I have read that the Dell Social Networks people forward this sort of stuff to the Dell Developers ...
Cheers
Bob
On Thu, 28 Jan 2021 at 11:46, Guenter Roeck linux@roeck-us.net wrote:
On 1/27/21 3:00 PM, Pali Rohár wrote:
On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Of course! We will just wait for Bob test results.
Guenter, now we have all needed information, fix is really needed in this form. So you can add my:
Reviewed-by: Pali Rohár pali@kernel.org
Applied (again)
Thanks, Guenter
linux-stable-mirror@lists.linaro.org
-
Bob Hepple -
Guenter Roeck -
Pali Rohár -
Thomas Hebb -
Tom Hebb