Log mei_irq_write_handler() errors to prevent silent IRQ handling failures.
Fixes: 962ff7bcec24 ("mei: replace callback structures used as list head by list_head") Cc: stable@vger.kernel.org # 4.11+ Signed-off-by: Wentao Liang vulab@iscas.ac.cn --- drivers/misc/mei/hw-me.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index d11a0740b47c..5df42a64b4db 100644 --- a/drivers/misc/mei/hw-me.c +++ b/drivers/misc/mei/hw-me.c @@ -1415,6 +1415,8 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void *dev_id) if (dev->pg_event != MEI_PG_EVENT_WAIT && dev->pg_event != MEI_PG_EVENT_RECEIVED) { rets = mei_irq_write_handler(dev, &cmpl_list); + if (rets) + dev_err(dev->dev, "mei_irq_write_handler ret = %d.\n", rets); dev->hbuf_is_ready = mei_hbuf_is_ready(dev); }
On Thu, Feb 20, 2025 at 09:34:35PM +0800, Wentao Liang wrote:
Log mei_irq_write_handler() errors to prevent silent IRQ handling failures.
Fixes: 962ff7bcec24 ("mei: replace callback structures used as list head by list_head") Cc: stable@vger.kernel.org # 4.11+ Signed-off-by: Wentao Liang vulab@iscas.ac.cn
drivers/misc/mei/hw-me.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index d11a0740b47c..5df42a64b4db 100644 --- a/drivers/misc/mei/hw-me.c +++ b/drivers/misc/mei/hw-me.c @@ -1415,6 +1415,8 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void *dev_id) if (dev->pg_event != MEI_PG_EVENT_WAIT && dev->pg_event != MEI_PG_EVENT_RECEIVED) { rets = mei_irq_write_handler(dev, &cmpl_list);
if (rets)dev_err(dev->dev, "mei_irq_write_handler ret = %d.\n", rets);2.42.0.windows.2
How was this found and tested?
And why print an error message in an irq handler, isn't that going to be messy? What can the user do with this message?
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Wentao Liang