This series adds support for camera clock controller base driver, bindings and DT support on sc8180x platform.
Signed-off-by: Satya Priya Kakitapalli quic_skakitap@quicinc.com --- Changes in v2: - New patch [1/4] to add all the missing gcc bindings along with the required GCC_CAMERA_AHB_CLOCK - As per Konrad's comments, add the camera AHB clock dependency in the DT and yaml bindings. - As per Vladimir's comments, update the Kconfig to add the SC8180X config in correct alphanumerical order. - Link to v1: https://lore.kernel.org/r/20250422-sc8180x-camcc-support-v1-0-691614d13f06@q...
--- Satya Priya Kakitapalli (4): dt-bindings: clock: qcom: Add missing bindings on gcc-sc8180x dt-bindings: clock: Add Qualcomm SC8180X Camera clock controller clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver arm64: dts: qcom: Add camera clock controller for sc8180x
.../bindings/clock/qcom,sc8180x-camcc.yaml | 67 + arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 + drivers/clk/qcom/Kconfig | 10 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/camcc-sc8180x.c | 2897 ++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-sc8180x.h | 12 + include/dt-bindings/clock/qcom,sc8180x-camcc.h | 181 ++ 7 files changed, 3182 insertions(+) --- base-commit: bc8aa6cdadcc00862f2b5720e5de2e17f696a081 change-id: 20250422-sc8180x-camcc-support-9a82507d2a39
Best regards,
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org Signed-off-by: Satya Priya Kakitapalli quic_skakitap@quicinc.com --- include/dt-bindings/clock/qcom,gcc-sc8180x.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/include/dt-bindings/clock/qcom,gcc-sc8180x.h b/include/dt-bindings/clock/qcom,gcc-sc8180x.h index e364006aa6eab8c1c9f8029a67087d09a73cee51..bff83d8edb5e4abaef496a75387abafb152b1480 100644 --- a/include/dt-bindings/clock/qcom,gcc-sc8180x.h +++ b/include/dt-bindings/clock/qcom,gcc-sc8180x.h @@ -249,6 +249,18 @@ #define GCC_UFS_MEM_CLKREF_EN 239 #define GCC_UFS_CARD_CLKREF_EN 240 #define GPLL9 241 +#define GCC_CAMERA_AHB_CLK 242 +#define GCC_CAMERA_XO_CLK 243 +#define GCC_CPUSS_DVM_BUS_CLK 244 +#define GCC_CPUSS_GNOC_CLK 245 +#define GCC_DISP_AHB_CLK 246 +#define GCC_DISP_XO_CLK 247 +#define GCC_GPU_CFG_AHB_CLK 248 +#define GCC_GPU_IREF_CLK 249 +#define GCC_NPU_CFG_AHB_CLK 250 +#define GCC_VIDEO_AHB_CLK 251 +#define GCC_VIDEO_XO_CLK 252 +#define GCC_AGGRE_UFS_CARD_2_AXI_CLK 253
#define GCC_EMAC_BCR 0 #define GCC_GPU_BCR 1
On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org
What sort of bug is being fixed here? This needs to be clearly expressed in commit msg - bug or observable issue.
Best regards, Krzysztof
On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote:
On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org
What sort of bug is being fixed here? This needs to be clearly expressed in commit msg - bug or observable issue.
The multi-media AHB clocks are needed to create HW dependency in the multimedia CC dt blocks and avoid any issues. They were not defined in the initial bindings.
Sure, I'll add the details in the commit text.
Best regards, Krzysztof
On 05/05/2025 11:43, Satya Priya Kakitapalli wrote:
On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote:
On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org
What sort of bug is being fixed here? This needs to be clearly expressed in commit msg - bug or observable issue.
The multi-media AHB clocks are needed to create HW dependency in the multimedia CC dt blocks and avoid any issues. They were not defined in the initial bindings.
Sure, I'll add the details in the commit text.
I don't understand what is the bug here. You just described missing feature.
Best regards, Krzysztof
On 5/5/25 11:46 AM, Krzysztof Kozlowski wrote:
On 05/05/2025 11:43, Satya Priya Kakitapalli wrote:
On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote:
On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org
What sort of bug is being fixed here? This needs to be clearly expressed in commit msg - bug or observable issue.
The multi-media AHB clocks are needed to create HW dependency in the multimedia CC dt blocks and avoid any issues. They were not defined in the initial bindings.
Sure, I'll add the details in the commit text.
I don't understand what is the bug here. You just described missing feature.
i.e. this patch is fine, but the fixes tag doesn't apply, as it doesn't really fix anything on its own
Konrad
On 5/5/2025 6:52 PM, Konrad Dybcio wrote:
On 5/5/25 11:46 AM, Krzysztof Kozlowski wrote:
On 05/05/2025 11:43, Satya Priya Kakitapalli wrote:
On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote:
On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
Add all the missing clock bindings for gcc-sc8180x.
Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Cc: stable@vger.kernel.org
What sort of bug is being fixed here? This needs to be clearly expressed in commit msg - bug or observable issue.
The multi-media AHB clocks are needed to create HW dependency in the multimedia CC dt blocks and avoid any issues. They were not defined in the initial bindings.
Sure, I'll add the details in the commit text.
I don't understand what is the bug here. You just described missing feature.
i.e. this patch is fine, but the fixes tag doesn't apply, as it doesn't really fix anything on its own
Okay, I'll drop the fixes tag.
Konrad
linux-stable-mirror@lists.linaro.org
-
Konrad Dybcio -
Krzysztof Kozlowski -
Satya Priya Kakitapalli